feat: add NCCL timeout config, stale ZMQ socket cleanup, OmegaConfig resolvers#2862
Open
puneeshkhanna wants to merge 1 commit into
Open
feat: add NCCL timeout config, stale ZMQ socket cleanup, OmegaConfig resolvers#2862puneeshkhanna wants to merge 1 commit into
puneeshkhanna wants to merge 1 commit into
Conversation
…f resolvers - Add configurable NCCL collective timeout via NRL_DIST_TIMEOUT_MINUTES env var (default 10 mins) to handle slow cross-node collectives during HF->Megatron reshard and policy->vLLM refit. - Self-heal stale IPC socket files in maybe_init_zmq() to prevent EADDRINUSE errors after unclean exits (crash, kill -9, OOM). - Register "add" and "sub" OmegaConf resolvers for use in config files. Signed-off-by: Puneesh Khanna <puneesh.khanna@tii.ae>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
max_input_tokens: ${sub:${policy.generation.vllm_cfg.max_model_len}, ${policy.generation.max_new_tokens}}
max_output_tokens: ${policy.generation.max_new_tokens}
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
New tests not required.
/review-pr comments below:
Files changed: 3
Findings (scored ≥80)
None. LGTM.
Filtered (scored <80)
All candidates were either consistent with codebase conventions (env var ValueError — 92% confidence it's a non-issue) or pre-existing gaps (missing resolver tests). No
new bugs or guideline violations introduced by this diff.
The changes are clean and ready.