DRAFT fix: prefer real NeMo-Gym package in actor#2867
Open
snowmanwwg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Wenwen Gao <wenweng@cw-dfw-cs-001-vscode-01.cm.cluster>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes the old NeMo-Gym PARENT_DIR crash in NeMo-RL.
When NeMo-RL starts a NeMo-Gym actor, Python could accidentally grab the wrong folder named nemo_gym:
The wrong one is just an examples folder, so it does not contain PARENT_DIR. That caused:
ImportError: cannot import name 'PARENT_DIR' from 'nemo_gym'
The PR makes NeMo-RL do this before starting NeMo-Gym:
It also fixes a smaller environment bug: NeMo-RL was setting VIRTUAL_ENV to the Python executable path like:
.../bin/python
but it should point to the venv folder:
.../
So the PR makes that correct too.
Before your PR is "Ready for review"
Pre checks:
Additional Information