fix(megatron): only build the MTP loss mask when MTP is enabled#2876
Open
yfw wants to merge 2 commits into
Open
fix(megatron): only build the MTP loss mask when MTP is enabled#2876yfw wants to merge 2 commits into
yfw wants to merge 2 commits into
Conversation
Gate mtp_loss_mask creation on mtp_num_layers, and add a regression test for the VLM sequence-packing guard. Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yfw
added
the
CI:Lfast
Contributor
Author
|
/ok to test b3884ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Gate mtp_loss_mask creation on mtp_num_layers, and add a regression test for the VLM sequence-packing guard.
Issues
Closes #2869
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information