Skip to content

[DO NOT MERGE] Cye/mfsdp devgrad revert#4428

Draft
cspades wants to merge 2 commits intoNVIDIA:devfrom
cspades:cye/mfsdp-devgrad-mlperf-revert
Draft

[DO NOT MERGE] Cye/mfsdp devgrad revert#4428
cspades wants to merge 2 commits intoNVIDIA:devfrom
cspades:cye/mfsdp-devgrad-mlperf-revert

Conversation

@cspades
Copy link
Copy Markdown
Member

@cspades cspades commented Apr 22, 2026

What does this PR do ?

  • For segfault / gradnorm issue.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@cspades cspades self-assigned this Apr 22, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 22, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gautham-kollu gautham-kollu changed the title [DO NOT MERGE] Cye/mfsdp devgrad mlperf revert [DO NOT MERGE] Cye/mfsdp devgrad revert Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant