This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Zcharpy/bug 4472305#100
Open
Zenodia wants to merge 21 commits into
Open
Conversation
Signed-off-by: Gerald Shen <geshen@nvidia.com> Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
…_sft to ensure persist into .nemo ckpt
for more information, see https://pre-commit.ci
yidong72
reviewed
Feb 8, 2024
yidong72
reviewed
Feb 8, 2024
yidong72
reviewed
Feb 8, 2024
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Adding steerable_attributes inside of NeMo-Aligner/examples/nlp/gpt/conf/gpt_sft.yaml files , in order to ensure whenever SteerLM training is finished, the .nemo file will also save these steerable_attributes into the model_config.yaml file
Changelog
packaging steerable_attributes into .nemo tar file and make sure these attributes exists in the model_config.yaml after untar .nemo
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1andvalidation?Additional Information