Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Zcharpy/bug 4472305#100

Open
Zenodia wants to merge 21 commits into
NVIDIA:mainfrom
Zenodia:zcharpy/bug-4472305
Open

Zcharpy/bug 4472305#100
Zenodia wants to merge 21 commits into
NVIDIA:mainfrom
Zenodia:zcharpy/bug-4472305

Conversation

@Zenodia
Copy link
Copy Markdown

@Zenodia Zenodia commented Feb 5, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Adding steerable_attributes inside of NeMo-Aligner/examples/nlp/gpt/conf/gpt_sft.yaml files , in order to ensure whenever SteerLM training is finished, the .nemo file will also save these steerable_attributes into the model_config.yaml file

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.
    packaging steerable_attributes into .nemo tar file and make sure these attributes exists in the model_config.yaml after untar .nemo

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

gshennvm and others added 17 commits January 23, 2024 10:13
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 5, 2024
Comment thread examples/nlp/gpt/conf/gpt_sft.yaml Outdated
Comment thread examples/nlp/gpt/conf/gpt_sft.yaml Outdated
Comment thread examples/nlp/gpt/conf/gpt_sft.yaml Outdated
Zenodia and others added 2 commits February 9, 2024 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants