This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Alit/draftpp#106
Open
JRD971000 wants to merge 25 commits into
Open
Conversation
for more information, see https://pre-commit.ci
gshennvm
requested review from
SahilJain314
and removed request for
gshennvm
Contributor
There was a problem hiding this comment.
Is this file required after the move to SupervisedTrainer? I see it in the import statement for train_sd_draft.py, but nowhere else.
Signed-off-by: ataghibakhsh <ataghibakhsh@nvidia.com>
Signed-off-by: ataghibakhsh <ataghibakhsh@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: ataghibakhsh <ataghibakhsh@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: ataghibakhsh <ataghibakhsh@nvidia.com>
…into alit/draftpp
for more information, see https://pre-commit.ci
Signed-off-by: ataghibakhsh <ataghibakhsh@nvidia.com>
…into alit/draftpp
| @@ -0,0 +1,55 @@ | |||
| #!/bin/bash | |||
| PROJECT="NeMo-draft+" | |||
| WANDB="8256bec8f68d1a0ee4a3208685a8db0474d3806b" | |||
Contributor
There was a problem hiding this comment.
remove your wandb key
| exp_manager.wandb_logger_kwargs.name=${ACTOR_WANDB_NAME} \ | ||
| exp_manager.resume_if_exists=False \ | ||
| exp_manager.explicit_log_dir=${DIR_SAVE_CKPT_PATH} \ | ||
| exp_manager.wandb_logger_kwargs.project=${PROJECT} #&> /opt/nemo-aligner/examples/mm/logs/draft_log.txt & |
Collaborator
Author
There was a problem hiding this comment.
Sorry the launcher script should be removed altogether I guess, right?
| @@ -0,0 +1,154 @@ | |||
| # Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
copyright notices -> 2024 (all new files)
| VAE_CKPT="/opt/nemo-aligner/checkpoints/vae.bin" | ||
| ACTOR_WANDB_NAME=DRaFT+-ws-LR_${LR}-KL_${KL_COEF}-BS_${ACTOR_GLOBAL_BATCH_SIZE} | ||
| DIR_SAVE_CKPT_PATH="/opt/nemo-aligner/draft_p_saved_ckpts" | ||
| DATASET_PATH="/opt/nemo-aligner/datasets/animals45.tar" |
Contributor
There was a problem hiding this comment.
Are we shipping animals45.tar? if not, can we remove/make generic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding DRaFT algorithm for SD fine-tuning
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1andvalidation?Additional Information