Skip to content

fix(docs): constrain landing terminal height#1269

Merged
drew merged 1 commit intomainfrom
dock-fixes
May 8, 2026
Merged

fix(docs): constrain landing terminal height#1269
drew merged 1 commit intomainfrom
dock-fixes

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 8, 2026

Summary

Fix the landing page terminal demo so the animated shell command renders as a compact two-line terminal instead of reserving extra vertical space below the commands.

Related Issue

None.

Changes

  • Constrain the terminal body to two fixed command rows.
  • Contain the animated command argument swap in a fixed one-line box.
  • Preserve horizontal overflow for narrow viewports without adding vertical space.

Testing

  • mise run docs passes
  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 8, 2026 17:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

@drew drew enabled auto-merge (squash) May 8, 2026 17:14
Copy link
Copy Markdown
Collaborator

@TaylorMutch TaylorMutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2026-05-08 at 10 15 19 AM

After
Screenshot 2026-05-08 at 10 15 23 AM

LGTM

@drew drew merged commit b74d24b into main May 8, 2026
24 checks passed
@drew drew deleted the dock-fixes branch May 8, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants