Relax empty pencil check during grid descriptor creation to allow more flexibility#103
Merged
romerojosh merged 4 commits intomainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
…e flexibility. Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
This was referenced Feb 11, 2026
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative version of #102. Fixes #101.
As it stands right now, cuDecomp will not allow users to create grid descriptors that potentially result in situations where processes have empty pencils with zero elements in any pencil orientation (i.e. x-pencils, y-pencils, z-pencils), which is very conservative. Users might desire using cuDecomp on only a subset of the pencil orientations and might not care if the other orientations have empty processes. For example, in #101, that user is interested in using halo-exchange routines on z-pencils with
N x N x 1dimensions. The current empty pencil checks will not allow this usage at all due to thex-andy-pencil orientations attempting to distribute the1dimension.This PR addresses this limitation by:
Unlike #102, this PR explicitly disallows running cuDecomp operations on configurations that will encounter empty pencils and throws an error. Effectively, this replaces the more general and conservative empty pencil check in
cudecompGridDescCreateto more targeted check that only triggers if a user attempts an unsupported operation. This ultimately makes the library more flexible by allowing more use cases, but also does not add the complexity of handling communicators with empty pencils.