Revert "Use native NVSHMEM synchronization APIs in NVSHMEM backends (#107)"#110
Merged
romerojosh merged 1 commit intomainfrom Mar 8, 2026
Merged
Revert "Use native NVSHMEM synchronization APIs in NVSHMEM backends (#107)"#110romerojosh merged 1 commit intomainfrom
romerojosh merged 1 commit intomainfrom
Conversation
romerojosh
added a commit
that referenced
this pull request
Mar 11, 2026
* Revert "Revert "Use native NVSHMEM synchronization APIs in NVSHMEM backends (#107)" (#110)" This reverts commit e401242. Signed-off-by: Josh Romero <joshr@nvidia.com> * Apply NVSHMEM_CUMEM_GRANULARITY workaround for older NVSHMEM versions. Signed-off-by: Josh Romero <joshr@nvidia.com> * Increase NVSHMEM_CUMEM_GRANULARITY to maximum of 2 GiB. Signed-off-by: Josh Romero <joshr@nvidia.com> --------- Signed-off-by: Josh Romero <joshr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further testing of #107 uncovered issues with NVSHMEM versions older than 3.3.24. Reverting those changes for now until an appropriate workaround is in place.