Skip to content

Route valid_if through memory resources - #24085

Draft
nirandaperera wants to merge 1 commit into
NVIDIA:mainfrom
nirandaperera:valid-if-memory-resources
Draft

Route valid_if through memory resources#24085
nirandaperera wants to merge 1 commit into
NVIDIA:mainfrom
nirandaperera:valid-if-memory-resources

Conversation

@nirandaperera

Copy link
Copy Markdown
Contributor

Description

A part of #20780.

  • Port cudf::detail::valid_if to take cudf::memory_resources and route scan scratch separately from the returned null mask.
  • Update validity-mask construction callers to pass output and temporary resources explicitly.
  • Add allocation-routing coverage using BaseFixtureWithHarness.

Test plan

  • Pre-commit checks on all changed files
  • Build BITMASK_TEST, LISTS_TEST, and GROUPBY_TEST
  • BITMASK_TEST (54/54 passed)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@nirandaperera nirandaperera added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 9, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant