Skip to content

TEST: Remove legacy reduction concurrency smoke test - #24119

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/remove-reduction-concurrency-smoke-test
Open

TEST: Remove legacy reduction concurrency smoke test#24119
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/remove-reduction-concurrency-smoke-test

Conversation

@vyasr

@vyasr vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Removes an undocumented 2019 concurrency smoke test for Series reductions. It had no result assertions or linked regression history; ordinary reduction correctness remains covered by the existing test matrix.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 10, 2026 21:29
@vyasr
vyasr requested a review from bdice September 10, 2026 21:29
@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6b6c38a2-883e-4f40-abf4-7a203d746927

📥 Commits

Reviewing files that changed from the base of the PR and between e78c254 and 83efd3d.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/series/methods/test_reductions.py
💤 Files with no reviewable changes (1)
  • python/cudf/cudf/tests/series/methods/test_reductions.py

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Removed an unused import and a concurrent series-reduction test.
    • Existing reduction test coverage remains unchanged.

Walkthrough

Changes

Reduction test cleanup

Layer / File(s) Summary
Remove thread-pool test coverage
python/cudf/cudf/tests/series/methods/test_reductions.py
Removed the unused ThreadPoolExecutor import and the concurrent series-reduction test. Other reduction tests remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 83efd

This cleanup removes obsolete test code without changing production behavior or established reduction correctness coverage. The change is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains the removal of the legacy concurrency smoke test and states that existing reduction coverage remains unchanged.
Title check ✅ Passed The title clearly identifies the test change and matches the pull request's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant