-
Notifications
You must be signed in to change notification settings - Fork 125
Fix doc version update script to handle new url #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc version update script to handle new url #810
Conversation
📝 WalkthroughWalkthroughThese changes update the documentation version management system. The utility script is modified to use absolute URLs, update copyright information, and implement version entry cleanup logic, while the versions JSON file is updated to reflect the new latest version 26.04.00. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci/utils/update_doc_versions.py (1)
34-39: Remove"preferred"key regardless of its value.
if version_entry.get("preferred"):won’t remove apreferred: falsekey, leaving inconsistent schema and potentially confusing downstream consumers that check key presence.✅ Proposed fix
- if version_entry.get("preferred"): - version_entry.pop("preferred", None) + if "preferred" in version_entry: + version_entry.pop("preferred", None)
|
/merge |
Fix doc version update script to handle new url
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.