Fix panama headers when RAPIDS_VERSION points to a PR branch - #185
Open
imotov wants to merge 6 commits into
Open
Fix panama headers when RAPIDS_VERSION points to a PR branch#185imotov wants to merge 6 commits into
imotov wants to merge 6 commits into
Conversation
This is a follow up for NVIDIA#181. It ensures that panama-bindings/generate-bindings.sh script is using correct headers (from PR) and tests don't pick up libcuvs that was preinstalled as part of conda environment.
imotov
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test e95eee3 |
Contributor
Author
|
/ok to test 13fba23 |
KyleFromNVIDIA
requested changes
Jul 28, 2026
| export CMAKE_PREFIX_PATH="$LIBCUVS_DIR" | ||
| # Uninstall the conda-installed libcuvs so it cannot shadow the PR artifact | ||
| # at runtime. | ||
| conda remove --yes --force-remove libcuvs |
Member
There was a problem hiding this comment.
I understand the reasoning, but I'm hesitant to have a build.sh that modifies the environment in this manner. Perhaps it would be better to export cuvs_ROOT instead.
robertmaynard
approved these changes
Jul 29, 2026
robertmaynard
self-requested a review
July 29, 2026 19:23
|
Removing my approval given the issues that Kyle has brought up |
bdice
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #181. It ensures that panama-bindings/generate-bindings.sh script is using correct headers (from PR) and tests don't pick up libcuvs that was preinstalled as part of conda environment.