fix(data): apply --start-time-sec to COLMAP camera frame timestamps - #182
Merged
janickm merged 1 commit intoSep 10, 2026
Merged
Conversation
ColmapCamera.timestamps_us was declared as a @Property that also took a start_time_sec parameter. A property cannot receive arguments, so every access used the signature default of 0.0 and the configured offset never reached the camera frames. The offset did reach the declared sequence interval and the SfM point cloud's reference timestamp, so a non-zero --start-time-sec left frames at t=0 while the interval began at the offset. Since the writer asserts frame containment rather than clamping, conversion failed outright. Carry start_time_sec on ColmapCamera and read it from self. Adds a data-free regression test; the package had no test target before.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ColmapCamera.timestamps_uswas declared as a@propertythat also took astart_time_secparameter. A property cannot receive arguments, so everyaccess used the signature default of
0.0and the configured offset neverreached the camera frames.
The offset did reach the declared sequence interval
(
colmap/converter.py:256-257) and the SfM point cloud's reference timestamp(
:351). So with a non-zero--start-time-secthe sequence interval began atthe offset while frames stayed at t=0. Since the writer asserts frame
containment rather than clamping, conversion fails outright:
Carries
start_time_seconColmapCameraand reads it fromself. Bothconstruction sites pass it through.
Found while fact-checking the ncore skill in #181 against the source.
Testing
Adds
converter_test.py; the COLMAP package had no test target before. It isdata-free and runs in CI, following the
argoverse2:pytest_utilsprecedent.Verified as a real regression guard: reverting the property to the old form
makes it fail, and restoring the fix makes it pass.
Type of Change
Checklist
bazel test //tools/...)bazel run //:format)