fix(cloud-tasks): pin the chart to an image tag that exists - #1575
Open
balajinvda wants to merge 1 commit into
Open
fix(cloud-tasks): pin the chart to an image tag that exists#1575balajinvda wants to merge 1 commit into
balajinvda wants to merge 1 commit into
Conversation
The self-managed stack publish lane has failed repeatedly on: ncp-dev/nvct-service-oss:1.64.1 ... not found [http 404] The chart pinned appVersion and image tag 1.64.1. cloud-tasks v1.64.1 was released on 2026-08-27, but at that point the release config had only two image destinations, nvcf-cloud-tasks and kaze. The nvct-service-oss destination the chart reads from was added a week later, on 2026-09-03, so 1.64.1 was never published under that repository name and never will be without re-running that release. 1.65.0 was released on 2026-09-04, after the destination existed, and nvct-service-oss:1.65.0 is present in ncp-dev (digest sha256:2d0f394e10a4ed3945bf7ecb93031c1268cabea1214ecfc64da4b6a5c2c9e6e1). Applied with tools/ci/chart-version-bumper, which moved appVersion and the matching image tag together after confirming they agreed. Co-authored-by: Balaji Ganesan <bganesan@nvidia.com> Signed-off-by: Balaji Ganesan <bganesan@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe Helm chart application version and the Changesnvct-api release configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the nvct-api chart and deployed image version to 1.65.0. The chart and image tag remain aligned, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The self-managed stack publish lane in nvcf-internal has failed repeatedly with:
The chart pinned
appVersionand image tag1.64.1. That tag does not exist undernvct-service-ossand never will.cloud-tasks
v1.64.1was released 2026-08-27. At that point the release config had two image destinations,nvcf-cloud-tasksandkaze. Thenvct-service-ossdestination the chart reads from was added a week later, on 2026-09-03, so 1.64.1 was published under the old names only.v1.65.0was released 2026-09-04, after the destination existed, and its promote job pushed successfully:What changed
appVersionand the image tag move together from 1.64.1 to 1.65.0.Applied with
tools/ci/chart-version-bumper, which confirmed the two fields agreed before moving them:Customer Release Notes
Not customer visible. Fixes a release pipeline failure.
Plan Summary
Not applicable.
Usage
Not applicable.
Testing
helm lintpasses on the chart. The target tag was verified present in ncp-dev by reading the promote job log for the 1.65.0 release rather than assuming it published.Notes
Skipping 1.64.2 is deliberate: it was released 2026-09-04 at 01:14, still before the 2026-09-03 destination change had a release run through it, and 1.65.0 is the first version confirmed present under
nvct-service-oss.Worth a follow-up: nothing failed when 1.64.1 was published without the destination that the chart reads from. The chart pointed at a repository the release was not writing to, and the only signal was a stack publish failure a week later. The chart-to-service edge added in #1215 plus the bumper in #1222 close the version-drift half of this; the destination-versus-chart mismatch is a separate gap.
References
None
Related Merge Requests/Pull Requests
None
Dependencies
None
Github commit:
fix(cloud-tasks): pin the chart to an image tag that exists
Co-authored-by: Balaji Ganesan bganesan@nvidia.com
Summary by CodeRabbit