Skip to content

fix(icms-fnds): Sending event ledger events in async mode #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shobham-nv merged 1 commit into from
Sep 8, 2026
Merged

fix(icms-fnds): Sending event ledger events in async mode #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/bazel-*

# IDE / editor
.bazelbsp/
.idea/
.vscode/
*.swp
Expand Down
16 changes: 14 additions & 2 deletions ...ment/icms-core/src/main/java/com/nvidia/icms/service/FunctionDeploymentStagesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.time.temporal.ChronoUnit;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Service;
Expand Down Expand Up @@ -81,7 +82,19 @@ public void sendFunctionDeploymentStage(
event,
instanceRequest.getDeploymentId(),
instanceRequest.getGpuSpecificationId());
functionDeploymentStagesClient.sendFunctionDeploymentStage(fndsMessageModel);
CompletableFuture
.runAsync(() -> functionDeploymentStagesClient
.sendFunctionDeploymentStage(fndsMessageModel))
Comment thread
coderabbitai[bot] marked this conversation as resolved.
.exceptionally(exception -> {
log.error(
"Failed to send deployment stage to Event Ledger: "
+ "instanceId={}, functionId={}, ncaId={}",
fndsMessageModel.getInstanceId(),
fndsMessageModel.getFunctionId(),
fndsMessageModel.getNcaId(),
exception);
return null;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
});
}
} catch (Exception e) {
String message = String.format("Deployment stage cannot be sent, Error: %s",
Expand All @@ -97,7 +110,6 @@ public void sendFunctionDeploymentStage(
}
}


public FndsMessageV2Model toFndsMessageModel(
InstanceV2Entity instanceEntity, String functionId, String functionVersionId,
String event, UUID deploymentId, UUID gpuSpecificationId) {
Expand Down
Loading