fix: correct null-check variable after db_umem registration in ibdevx#80
Open
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA:develfrom
Open
fix: correct null-check variable after db_umem registration in ibdevx#80Doondi-Ashlesh wants to merge 1 commit intoNVIDIA:develfrom
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA:develfrom
Conversation
Author
|
Hi, just checking in on this PR, it should be ready to merge once reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a copy-paste bug in the ibdevx QP initialization code reported in #74.
After registering
db_umem, the null-check macro incorrectly checkswq_umeminstead ofdb_umem:If
db_umemregistration fails and returnsNULL, the error would go undetected (sincewq_umemwas already successfully registered and is non-null), leading to a later null dereference at line 447 whendb_umem->umem_idis accessed.Fixes #74