Repository navigation
Conversation
aw471
marked this pull request as ready for review
October 7, 2026 12:49
Reuse Standardize tensor operations directly inside the relational model, preserving fitted statistics and missing-value handling. Avoid constructing TableTensor auxiliary containers during compilation.
aw471
force-pushed
the
kumorelational-compile-relative-time
branch
from
October 7, 2026 12:53
c3dbbe7 to
2585807
Compare
aw471
changed the base branch from
kumorelational-compile-graph-preparation
to
main
October 7, 2026 12:53
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesTensor-level standardization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Relative-time normalization retains its fitted-state handling and shared tensor arithmetic; no actionable merge-blocking regression is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KumoRelational relative-time normalization failing during internal-model compilation. Graph/table preparation is a separate compilation blocker; this PR does not fix whole-model compilation by itself.
With graph preparation moved outside the internal model, this call exposes the relative-time failure on PyTorch 2.7.1 and 2.14:
The failing code inside
_get_rel_time()is:fullgraph=TrueUnsupported: torch.* op returned non-Tensorinvolvingstorage_offset()fullgraph=FalseInternalTorchDynamoError: AttributeError: 'StringTensor' object has no attribute '_valid'rel_timeis already a tensor. Wrapping it constructs auxiliary SDM containers that obstruct tracing. Extract the existingStandardizefit/transform arithmetic into shared tensor helpers and call them directly. Normalization, fitted state, and missing-value handling are unchanged; the arithmetic remains compiled.Focused checks include missing timestamps, constant columns, and entirely missing columns. Combined with the separate graph-preparation change, the equivalent prototype also passed pretrained RelBench cached prediction in both compilation modes, with maximum absolute differences from eager of
1.52e-6/4.08e-6; eager predictions exactly matched main. Full-model compiled fitting and GPU execution are not validated here.