feat(dsx): provider simulator#287
Conversation
Greptile SummaryThis PR adds a Confidence Score: 5/5Safe to merge; only one minor import-ordering style issue remains. All previously raised concerns (nil dereference in GetComputeInstances, unused struct fields, nodeIDs filtering) are addressed in this version. The single remaining finding is a P2 import ordering nit that does not affect runtime behaviour. pkg/registry/registry.go — import ordering nit Important Files Changed
Sequence DiagramsequenceDiagram
participant C as Caller
participant SP as simProvider
participant BP as baseProvider
participant CF as clientFactory
participant SC as simClient
participant IT as instance_topology
C->>SP: GenerateTopologyConfig(ctx, pageSize, instances)
SP->>BP: generateInstanceTopology(ctx, pageSize, instances)
BP->>CF: clientFactory()
CF-->>BP: simClient / error
BP->>SC: GetTopology(ctx, "", nodeIDs, pageSize, "")
SC-->>BP: TopologyResponse
BP->>IT: responseToClusterTopology(response, cis)
IT-->>BP: ClusterTopology
BP-->>SP: ClusterTopology
SP->>SP: topo.ToThreeTierGraph(NAME, instances, trimTiers, false)
SP-->>C: *topology.Vertex
note over C,SP: GetComputeInstances path (engine support)
C->>SP: GetComputeInstances(ctx)
SP->>CF: clientFactory()
CF-->>SP: simClient / error
SP->>SC: model.Instances
SC-->>C: []ComputeInstances
Reviews (5): Last reviewed commit: "feat(dsx): provider simulator" | Re-trigger Greptile |
Signed-off-by: Ravi Shankar <ravish@nvidia.com>
Description
Adds a simulator implementation for the latinum provider.
Checklist
git commit -s).