Skip to content

fix: Docker buildkit proxy setting for nv-gh-runners#296

Merged
ravisoundar merged 1 commit intomainfrom
gh-runner-fix
Apr 24, 2026
Merged

fix: Docker buildkit proxy setting for nv-gh-runners#296
ravisoundar merged 1 commit intomainfrom
gh-runner-fix

Conversation

@ravisoundar
Copy link
Copy Markdown
Collaborator

Description

Adds the proxy settings for the docker build kit setup to avoid issues while using Nvidia GH runners.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • All commits are signed off per DCO (git commit -s).

Signed-off-by: Ravi Shankar <ravish@nvidia.com>
@ravisoundar ravisoundar requested a review from dmitsh as a code owner April 24, 2026 17:08
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 24, 2026

Greptile Summary

Both Docker build workflows (docker.yml and docker-ib.yml) now pass buildkitd-config: /etc/buildkit/buildkitd.toml to docker/setup-buildx-action@v3, enabling the proxy configuration pre-installed on NVIDIA's linux-amd64-cpu16 self-hosted runners during BuildKit setup. The change is consistent across both files and is scoped to the custom runner environment.

Confidence Score: 5/5

Safe to merge — minimal, consistent change scoped to the custom NVIDIA runner environment.

The only finding is a P2 portability note about the hardcoded config path; no correctness, security, or data-integrity issues are present. Both files are treated identically and the runner label confirms the file will be present.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/docker.yml Adds buildkitd-config pointing to /etc/buildkit/buildkitd.toml for proxy support on NVIDIA GH runners
.github/workflows/docker-ib.yml Same buildkitd-config addition as docker.yml for the InfiniBand image build workflow

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Runner as linux-amd64-cpu16 Runner
    participant Buildx as docker/setup-buildx-action@v3
    participant BuildKit as BuildKit Daemon
    participant Registry as ghcr.io

    GHA->>Runner: Trigger workflow_dispatch
    Runner->>Buildx: Set up Buildx buildkitd-config: /etc/buildkit/buildkitd.toml
    Buildx->>Runner: Read /etc/buildkit/buildkitd.toml (proxy settings)
    Buildx->>BuildKit: Start daemon with proxy config
    BuildKit-->>Buildx: Daemon ready
    Runner->>BuildKit: docker/build-push-action (multi-platform build)
    BuildKit->>Registry: Push image (linux/amd64, linux/arm64)
Loading

Reviews (1): Last reviewed commit: "fix: Docker buildkit proxy setting for n..." | Re-trigger Greptile

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
buildkitd-config: /etc/buildkit/buildkitd.toml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Hard dependency on runner-local config file

docker/setup-buildx-action will fail with an error if /etc/buildkit/buildkitd.toml does not exist on the runner. Since both workflows are pinned to linux-amd64-cpu16 (NVIDIA's custom runner) this works today, but it would silently break if the runner label is ever changed to a standard GitHub-hosted runner. Consider documenting the runner prerequisite in a comment, or using the inline buildkitd-flags / config-inline parameter to embed the proxy settings directly in the workflow so it remains self-contained and portable.

@ravisoundar ravisoundar merged commit 08a7987 into main Apr 24, 2026
2 checks passed
@ravisoundar ravisoundar deleted the gh-runner-fix branch April 24, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants