fix: Docker buildkit proxy setting for nv-gh-runners#296
Conversation
Signed-off-by: Ravi Shankar <ravish@nvidia.com>
Greptile SummaryBoth Docker build workflows ( Confidence Score: 5/5Safe to merge — minimal, consistent change scoped to the custom NVIDIA runner environment. The only finding is a P2 portability note about the hardcoded config path; no correctness, security, or data-integrity issues are present. Both files are treated identically and the runner label confirms the file will be present. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Runner as linux-amd64-cpu16 Runner
participant Buildx as docker/setup-buildx-action@v3
participant BuildKit as BuildKit Daemon
participant Registry as ghcr.io
GHA->>Runner: Trigger workflow_dispatch
Runner->>Buildx: Set up Buildx buildkitd-config: /etc/buildkit/buildkitd.toml
Buildx->>Runner: Read /etc/buildkit/buildkitd.toml (proxy settings)
Buildx->>BuildKit: Start daemon with proxy config
BuildKit-->>Buildx: Daemon ready
Runner->>BuildKit: docker/build-push-action (multi-platform build)
BuildKit->>Registry: Push image (linux/amd64, linux/arm64)
Reviews (1): Last reviewed commit: "fix: Docker buildkit proxy setting for n..." | Re-trigger Greptile |
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| buildkitd-config: /etc/buildkit/buildkitd.toml |
There was a problem hiding this comment.
Hard dependency on runner-local config file
docker/setup-buildx-action will fail with an error if /etc/buildkit/buildkitd.toml does not exist on the runner. Since both workflows are pinned to linux-amd64-cpu16 (NVIDIA's custom runner) this works today, but it would silently break if the runner label is ever changed to a standard GitHub-hosted runner. Consider documenting the runner prerequisite in a comment, or using the inline buildkitd-flags / config-inline parameter to embed the proxy settings directly in the workflow so it remains self-contained and portable.
Description
Adds the proxy settings for the docker build kit setup to avoid issues while using Nvidia GH runners.
Checklist
git commit -s).