Conversation
Greptile SummaryThis PR adds documentation for the Confidence Score: 5/5Safe to merge — documentation and test fixture changes only, with no production code modifications. All findings are P2 style nits (em-dash inconsistency in overview.md, indentation in test-block.json). No logic or correctness issues were found. Model file references in payloads are valid, and directory references in docs point to real paths. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Topograph
participant TestProvider
Client->>Topograph: POST /v1/generate (provider.params.generateResponseCode)
alt generateResponseCode 4xx-5xx
Topograph-->>Client: Error response + errorMessage (no request ID)
else generateResponseCode 202
Topograph->>TestProvider: Enqueue request (after requestAggregationDelay)
Topograph-->>Client: 202 Accepted + request ID
loop Poll until done
Client->>Topograph: GET /v1/topology?uid=<id>
alt Still queued / processing
Topograph-->>Client: 202 Accepted
end
end
TestProvider->>Topograph: Process (load modelFileName, run engine)
alt topologyResponseCode 200
Topograph-->>Client: 200 OK + topology output
else topologyResponseCode 202
Topograph-->>Client: 202 Accepted (forever / until timeout)
else topologyResponseCode 4xx-5xx
Note over Topograph: Internal retries for 408/429/500/502/503/504
Topograph-->>Client: Error response + errorMessage
end
end
Reviews (3): Last reviewed commit: "chore(docs): add documentation about 'te..." | Re-trigger Greptile |
| curl -i "http://localhost:49021/v1/topology?uid=${uid}" | ||
| ``` | ||
|
|
||
| For ready-made regression payloads, see `tests/integration/` and `tests/payloads/`. |
There was a problem hiding this comment.
Test provider missing from overview navigation
docs/overview.md enumerates every provider under "Supported Environments" with a link to its doc page, but the new test provider is not listed there. A reader browsing the overview won't discover this page. Even a brief entry (e.g., under a separate "Development / Testing" heading) would make it discoverable without cluttering the production provider list.
f26f9f9 to
a0b3723
Compare
|
🌿 Preview your docs: https://nvidia-preview-pull-request-299.docs.buildwithfern.com/topograph |
…payloads Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 68.46% 68.13% -0.33%
==========================================
Files 82 81 -1
Lines 4842 4805 -37
==========================================
- Hits 3315 3274 -41
Misses 1395 1395
- Partials 132 136 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
add documentation about 'test' provider
update test payloads
Checklist
git commit -s).