Skip to content

Implement Ledger transaction signing - #942

Merged
Nanle-code merged 3 commits into
Nanle-code:masterfrom
Gojv-byte:2026-Wallet]-Implement-end-to-end-Ledger-transaction-signing
Aug 31, 2026
Merged

Implement Ledger transaction signing#942
Nanle-code merged 3 commits into
Nanle-code:masterfrom
Gojv-byte:2026-Wallet]-Implement-end-to-end-Ledger-transaction-signing

Conversation

@Gojv-byte

Copy link
Copy Markdown
Contributor

Summary
This PR adds end-to-end Ledger hardware wallet signing support to the dashboard’s transaction flow. It enables users to connect a Ledger device, reuse the active Ledger session, sign Stellar transaction XDR, and return a valid signed envelope for submission to the network.

What Changed
Added Ledger connection/session management with WebUSB/WebHID detection and Stellar app initialization
Implemented transaction signing for raw Stellar transaction objects and unsigned XDR envelopes
Validated network passphrase, derivation path, public key, and signature output before assembling the signed transaction
Added clear user-facing error handling for unsupported browsers, rejection, locked devices, and app state issues
Integrated the flow into the existing transaction signer UI and wallet state
Added test coverage for successful signing and rejection scenarios
Why
The app previously lacked a reliable Ledger signing path. This creates a gap for users who rely on hardware wallet security and prevents Ledger-based signing from being used in the transaction workflow.

Validation
Executed:
npx vitest run src/lib/wallet/tests/ledger.test.js

Result:

1 test file passed
3/3 tests passed

closes: #759

Impact
This closes the core Ledger signing gap in the wallet flow and gives users a secure, hardware-backed transaction signing path within the dashboard.

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@Gojv-byte Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

@Gojv-byte is attempting to deploy a commit to the nanle-code's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Manuelshub

Copy link
Copy Markdown
Collaborator

@Gojv-byte Please resolve the conflict

@Nanle-code
Nanle-code merged commit 137bd2c into Nanle-code:master Aug 31, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2026 Wallet] Implement end-to-end Ledger transaction signing

3 participants