Fix brownout requests in analytics logs missing user information; Dependency updates; Prevent duplicative CI runs#716
Merged
Merged
Conversation
The brownout logic needs to happen after the user information is fetched so that it can be properly logged. This helps ensure analytics during brownouts are useful so we can see exactly who encountered brownout responses.
The httpv2_prior_knowledge test changed behavior after upgrading openresty from 1.27.1.2 to 1.29.2.3. I suspect this was an nginx change somewhere along the way, but the new behavior actually makes more sense, so updating the test suite to match.
…ests These tests are somewhat finicky and fuzzy, so increasing some of the thresholds to better accommodate the sporadic failures seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix brownout requests in analytics logs missing user information.
The brownout logic needs to happen after the user information is fetched so that it can be properly logged. This helps ensure analytics during brownouts are useful so we can see exactly who encountered brownout responses.
Prevent duplicate PR and branch tests; Prevent concurrent test runs
Update dependencies