Fix native route middleware during in-app navigation - #253
Closed
wojt-janowski wants to merge 2 commits into
Closed
Conversation
…leware # Conflicts: # src/NativeServiceProvider.php
Member
|
Sorry for the turnaround on this. Superseded by #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252.
Problem
Route::native()returns a real Laravel route, so chained middleware runs when the screen is entered through the initial HTTP request. In-app navigation takes a different path:NativeRouterresolves the URI and mounts the component directly for push, replace, and hot-reload stack restoration.That means route middleware such as
auth,can, and custom guards can be silently skipped after the app starts. A protected native screen can therefore mount when reached from another native screen even though the same URL is guarded on cold start.Fix
The stored route is cloned before parameter binding, preventing navigation between values of the same route pattern from mutating earlier route state.
Verification
php84 vendor/bin/pest— 800 passed, 2,799 assertionsphp84 vendor/bin/phpstan analyse --no-progress— no errorsgit diff --checkpass4.0.1: in-app navigation mounted the protected componentRegression coverage includes allowed middleware, aliases and route parameters, auth/request/route context, push, replace, allowed and denied preload, exact redirect and 403 response preservation, exception reporting/rendering, and same-pattern parameter isolation.