fix(async): allow Symfony Process 8 - #367
Open
ngunyimacharia wants to merge 2 commits into
Open
Conversation
NativePHP dispatched native events and polls only on the root screen, so nested native components never received their #[On] handlers or had their #[Poll] timers driven by the host runloop. Extract the listener path so the same handler-resolution logic recurses into nativeChildComponents, and extend nextEventTimeout/runDuePolls with the same recursion. Keep the protected signature of dispatchNativeEvent() unchanged and guard the named-binding whole-payload fallback so existing one-array-param listeners still work. Add Pest coverage for child #[Poll] recursion, child #[On] delivery, and child-poll timeout aggregation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symfony/process8.x alongside the existing 6.x and 7.x supportWhy
The current
^6.2|^7.0constraint prevents Composer from resolving #228 in consumers whose policy blocks all matching Symfony 6/7 releases for advisories, even when they already run Symfony Process 8.The package requires PHP
^8.4, which satisfies Symfony Process 8. Direct Process usage on this branch stays within APIs available in Symfony 8.Verification
composer validate --strictSymfony\Component\Processusage against Symfony 8A full upstream
composer update --dry-runremains blocked locally by an unrelated PHP 8.5 / legacy test dependency conflict (orchestra/testbench/ Pest / PHPUnit), not this constraint.