Skip to content

fix(ios): theme the drawer panel and inset it below the status bar #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodyPChristian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): theme the drawer panel and inset it below the status bar #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion resources/ios/NativeUIDrawerHost.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ struct NativeDrawerHost<Content: View>: View {

@ObservedObject private var state = DrawerHostState.shared
@Environment(\.accessibilityReduceMotion) private var reduceMotion
@Environment(\.nativeUITheme) private var theme
@State private var dragOffset: CGFloat = 0

private let edgeSwipeThreshold: CGFloat = 30
Expand Down Expand Up @@ -223,10 +224,21 @@ struct NativeDrawerHost<Content: View>: View {
NodeView(node: child).equatable()
}
}
// The panel ignores the safe area so its background reaches the top
// of the screen; without this inset the CONTENT does too, and the
// first row slides under the status bar. An app that pins
// UIUserInterfaceStyle sees this at every launch, not just on a
// notched device in landscape.
.padding(.top, windowSafeAreaTop)
}
.frame(width: width)
.frame(maxHeight: .infinity)
.background(Color(.systemBackground))
// The THEME background, not Color(.systemBackground). The drawer's own
// content paints only as tall as it is, so everything below the last
// row fell through to the system colour — white on a light-pinned app,
// regardless of the site's palette. A themed panel that turns white
// halfway down reads as a rendering fault, because it is one.
.background(theme.background)
}

// MARK: - Gesture settling
Expand Down
Loading