Skip to content

fix(android): reserve navigation bar slot for drawer #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsdatarocks wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(android): reserve navigation bar slot for drawer #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be241f
fix(android): reserve navigation slot for drawer
jsdatarocks Aug 16, 2026
be75f17
test(android): cover drawer navigation slot registration
jsdatarocks Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resources/android/NativeUIChromeInit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ import com.nativephp.plugins.native_ui.ui.nuiThemeDefaultTypography
* application context for asset-backed font loading.
*/
fun registerNativeUIChrome(context: Context) {
NativeRootHostRegistry.register("native-ui.drawer", consumes = "native_drawer") { root, content ->
NativeRootHostRegistry.register(
"native-ui.drawer",
consumes = "native_drawer",
reservesNavigationBarSlot = true,
) { root, content ->
val drawerNode = root.children.firstOrNull { it.type == "native_drawer" }
NativeLayoutDrawerHost(drawerNode = drawerNode, content = content)
}
Expand Down
15 changes: 15 additions & 0 deletions tests/NativeUIChromeInitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

test('registers the Android drawer host with navigation bar slot reservation', function () {
$source = file_get_contents(dirname(__DIR__).'/resources/android/NativeUIChromeInit.kt');
$matched = preg_match(
'/NativeRootHostRegistry\.register\(\s*"native-ui\.drawer",(?<arguments>[^)]*)\)/s',
$source,
$registration,
);

expect($matched)->toBe(1)
->and($registration['arguments'])
->toMatch('/consumes\s*=\s*"native_drawer"/')
->toMatch('/reservesNavigationBarSlot\s*=\s*true/');
});