Repository navigation
Conversation
…2358) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DefaultDgsDataLoaderProvider built its ScheduledDataLoaderRegistry with a DISPATCH_NEVER default. That worked around java-dataloader 3.2.x OR-ing a loader's own predicate with the registry default (graphql-java/java-dataloader#138). Since 3.3.0 a loader's predicate is final, and DGS registers every loader with one, so the default only applied to loaders added by others, such as Spring GraphQL's BatchLoaderRegistry. Those were never dispatched by dispatchAll() and hung the query. Drop the override so the registry uses java-dataloader's DISPATCH_ALWAYS default. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jjacobs44
marked this pull request as ready for review
October 19, 2026 17:19
jjacobs44
requested review from
asibross,
iparadiso,
iuliiasobolevska,
kzwang,
paulbakker and
srinivasankavitha
as code owners
October 19, 2026 17:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loaders registered through Spring GraphQL's
BatchLoaderRegistryare never dispatched because the DGS registry defaults toDISPATCH_NEVER(fixes #2358).