Added external conditions Ipc endpoint#66
Open
kittycat2002 wants to merge 1 commit intoNightmareXIV:mainfrom
Open
Added external conditions Ipc endpoint#66kittycat2002 wants to merge 1 commit intoNightmareXIV:mainfrom
kittycat2002 wants to merge 1 commit intoNightmareXIV:mainfrom
Conversation
|
Review changes with Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to dynamic bridge, an endpoint for registering conditions from other plugins, currently it adds 2 condition types, a standard filter much like the biomes one, and one where all selected conditions must be true for the condition to pass.
I have created an example project for an implementation of this: https://github.com/kittycat2002/DynamicBridge-ProviderTest
This pull request is also dependent on a pull request for ECommons: NightmareXIV/ECommons#162