Windows platform support and multi-instance workspace fix#52
Open
intisy wants to merge 4 commits intoNomadcxx:mainfrom
Open
Windows platform support and multi-instance workspace fix#52intisy wants to merge 4 commits intoNomadcxx:mainfrom
intisy wants to merge 4 commits intoNomadcxx:mainfrom
Conversation
Owner
|
Thanks man, this looks interesting, let me investigate. |
Owner
|
Hey @intisy, thanks for the PR mate — Windows support is definitely needed and your contribution sparked this work. I've opened a reworked version in #55 that builds on your idea but fixes a few issues I found during review:
You're credited as co-author on all the commits. Appreciate the contribution — the binary resolution approach and provider detection were solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds full Windows support and fixes workspace resolution when running multiple OpenCode instances.