Fix hang when decoding a corrupt subsequent zstd frame - #470
Merged
NobodyXu merged 2 commits intoJul 28, 2026
Conversation
zanieb
changed the title
zanieb
marked this pull request as ready for review
July 27, 2026 22:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
===========================
===========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NobodyXu
approved these changes
Jul 28, 2026
NobodyXu
left a comment
NobodyXu
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, LGTM! Will cut a release after merging
CathalMullan
pushed a commit
to CathalMullan/async-compression
that referenced
this pull request
Aug 7, 2026
## 🤖 New release * `async-compression`: 0.4.42 -> 0.4.43 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.43](Nullus157/async-compression@async-compression-v0.4.42...async-compression-v0.4.43) - 2026-07-28 ### Other - Fix hang when decoding a corrupt subsequent zstd frame ([Nullus157#470](Nullus157#470)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an infinite loop when decoding concatenated zstd frames with
multiple_members(true)and a later frame is corrupt.After completing a frame, the bufread decoder incorrectly treats the next decode as an empty-input poll even when input remains buffered, suppressing the corruption error and allowing the decoder to spin without making progress. Only request another poll when the current buffer is exhausted, ensuring errors from subsequent frames are propagated.