Conversation
The coordinate math, integer decoding, and geotransform validation behind the windowed COG reader are plain arithmetic on a geotransform and a raw array, so they now live in src/DataWrangling/OpenLandMap and can be unit-tested without ArchGDAL loaded. The extension keeps only the GDAL I/O. Also adds a network-gated download test over a small Iowa cropland window, excluded from the default suite like the other *_downloading tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
# Conflicts: # ext/NumericalEarthArchGDALExt.jl # test/runtests.jl
…ndow-src # Conflicts: # ext/NumericalEarthArchGDALExt/NumericalEarthArchGDALExt.jl # test/runtests.jl
xkykai
marked this pull request as ready for review
August 11, 2026 09:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windowed COG reader's coordinate math, integer decoding, and geotransform validation are plain arithmetic, so they move from
ext/NumericalEarthArchGDALExt.jlintosrc/DataWrangling/OpenLandMap/and are now unit-testable without ArchGDAL loaded. The extension keeps only the GDAL I/O.New in
src:validate_geographic_northup(geotransform)— axis-aligned, north-up checkvalidate_epsg4326(epsg)— acceptsnothingor4326cog_window_indices(geotransform, width, height, bbox)→(xoff, yoff, xsize, ysize)assemble_cog_window(raw, geotransform, xoff, yoff, scale, offset, nodata)→(longitude, latitude, data)Behavior is unchanged: same window, coordinates, decoding, and NetCDF output.
Also adds
test/test_openlandmap_downloading.jl, a live/vsicurlread over a small Iowa window, excluded from the default suite like the other*_downloadingtests.🤖 Generated with Claude Code