Implement river spread and river mixing - #486
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
xkykai
approved these changes
Aug 26, 2026
Comment on lines
+218
to
+219
| node_λφ(λc::AbstractVector, φc::AbstractVector, i, j) = (λc[i], φc[j]) | ||
| node_λφ(λc::AbstractMatrix, φc::AbstractMatrix, i, j) = (λc[i, j], φc[i, j]) |
Collaborator
There was a problem hiding this comment.
I wonder if it is possible to not define these functions and hard code at the call site instead since this does something very specific, up to you
Member
Author
There was a problem hiding this comment.
Applied Oceananigans' *node functions instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have a river inlet in the ocean, the salinity can drop to zero since the incoming freshwater sits on the first cell and creates a lens which never mixes.
For this reason this PR introduces a couple of common strategies in climate modeling
It also refactors a bit the river routing to apply also to datasets like JRA55