Skip to content

[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#133

Closed
Ricardoalso wants to merge 9 commits intoOCA:18.0from
camptocamp:18.0-mig-edi_exchange_deduplicate_oca
Closed

[18.0][MIG] edi_exchange_deduplicate_oca: Migration to 18.0#133
Ricardoalso wants to merge 9 commits intoOCA:18.0from
camptocamp:18.0-mig-edi_exchange_deduplicate_oca

Conversation

@Ricardoalso
Copy link
Contributor

@Ricardoalso Ricardoalso commented Jan 16, 2025

No description provided.

@Ricardoalso Ricardoalso force-pushed the 18.0-mig-edi_exchange_deduplicate_oca branch from 974c55c to 7fed647 Compare January 16, 2025 10:51
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 18, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 25, 2025
return records

def _edi_get_duplicates(self, count=None):
def _edi_get_duplicates(self, count=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed but seems to be more accurate IMHO. As the parameter count is here used as a boolean flag to choose between two behaviors: calling either search_count or search

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, that makes sense, I agree.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@github-actions github-actions bot closed this Nov 23, 2025
@Ricardoalso
Copy link
Contributor Author

superseded by #242 with the new edi_core_oca module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants