[19.0][MIG] sql export: Migration to 19.0#1128
Open
feketemihai wants to merge 112 commits intoOCA:19.0from
Open
[19.0][MIG] sql export: Migration to 19.0#1128feketemihai wants to merge 112 commits intoOCA:19.0from
feketemihai wants to merge 112 commits intoOCA:19.0from
Conversation
Add rollback after executing query as a double security with blacklist terms add known issue in readme
[FIX] encoding with mogrify [FIX] hide placeholder
Currently translated at 100,0% (50 of 50 strings) Translation: server-tools-10.0/server-tools-10.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-sql_export/de/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/
Currently translated at 100.0% (49 of 49 strings) Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/zh_CN/
Currently translated at 100.0% (49 of 49 strings) Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/pt_BR/
Co-Authored-By: David Beal <david.beal@akretion.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/
Currently translated at 100.0% (64 of 64 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_export/it/
Currently translated at 100.0% (64 of 64 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_export/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/
Currently translated at 100.0% (67 of 67 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/
This may be quite usefull to detect osbolete queries not used anymore in order to remove it
….export write_date/uid on query execution
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/
Currently translated at 100.0% (67 of 67 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/it/
Currently translated at 64.1% (43 of 67 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/tr/
Currently translated at 100.0% (67 of 67 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export/tr/
feketemihai
force-pushed
the
19.0-mig-sql_export
branch
2 times, most recently
from
78fa536 to
bf38b72
Compare
feketemihai
force-pushed
the
19.0-mig-sql_export
branch
from
bf38b72 to
39089e0
Compare
dannyadair
suggested changes
Mar 4, 2026
| ) | ||
| url = f"""web/content/?model={self._name}&id={self.id}& | ||
| filename_field=file_name&"field=binary_file&download=true& | ||
| filename={self.file_name}""" |
There was a problem hiding this comment.
I think this URL got jumbled in migration.
Suggested fix:
url = (
f"web/content/?model={self._name}&id={self.id}"
f"&filename_field=file_name&field=binary_file&download=true"
f"&filename={self.file_name}"
)
So "filename" is now "file_name" other than that I think the above is the correct f-string version of
https://github.com/OCA/reporting-engine/blob/18.0/sql_export/wizard/wizard_file.py#L88
P.S.: I think filename_field=filename in v18 (where the wizard field name was alreadt file_name) was wrong but without consequence because filename was given - see _get_stream_from() in odoo/addons/base/models/ir_binary.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.