Open
Conversation
LauraCForgeFlow
force-pushed
the
18.0-add-base_sequence_multi_company_template
branch
from
474caf3 to
c5b8b8c
Compare
LoisRForgeFlow
requested changes
Feb 24, 2026
Contributor
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Looks great! Some suggestions to improve:
- add a smart button to see the generated sequences from the template:
- add button in form view:
- add button in tree view (we can save the additional click on "actions")
Also, the name of the module could be just base_sequence_template, I don't see a reason to add the multi_company in the name as it is not extending base_multi_company or anything related. You are adding sequence templates that works with one or multiple companies like many standard modules. WDYT?
LauraCForgeFlow
force-pushed
the
18.0-add-base_sequence_multi_company_template
branch
from
c5b8b8c to
fbace80
Compare
LauraCForgeFlow
changed the title
Author
|
Thanks for the suggestions @LoisRForgeFlow! I completely agree, I have implemented the changes you proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.