[17.0][MIG] mail_template_attachment_i18n: Migration to 17.0#3559
Open
LauraCForgeFlow wants to merge 15 commits intoOCA:17.0from
Open
[17.0][MIG] mail_template_attachment_i18n: Migration to 17.0#3559LauraCForgeFlow wants to merge 15 commits intoOCA:17.0from
LauraCForgeFlow wants to merge 15 commits intoOCA:17.0from
Conversation
Currently translated at 100.0% (29 of 29 strings) Translation: server-tools-16.0/server-tools-16.0-mail_template_attachment_i18n Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-mail_template_attachment_i18n/it/
Currently translated at 100.0% (29 of 29 strings) Translation: server-tools-16.0/server-tools-16.0-mail_template_attachment_i18n Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-mail_template_attachment_i18n/it/
BhaveshHeliconia
approved these changes
Apr 14, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code review LGTM!
christian-ramos-tecnativa
suggested changes
Apr 14, 2026
christian-ramos-tecnativa
left a comment
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
It looks like the Partner language mode is not working. Can you take a look? The preview and template options works properly
LauraCForgeFlow
force-pushed
the
17.0-mig-mail_template_attachment_i18n
branch
from
71bcc53 to
fcb4cf3
Compare
OCA-git-bot
added
mod:mail_template_attachment_i18n
LauraCForgeFlow
force-pushed
the
17.0-mig-mail_template_attachment_i18n
branch
from
fcb4cf3 to
6da2f77
Compare
Author
|
Thanks for reviewing @christian-ramos-tecnativa! I have fixed the code to work correctly with the Partner language and added a test that covers that use case. I've also ported the changes to the v18 migration #3560, which depends on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration, added some testing.