[18] attachment_queue: Fix compatibility with queue job allow commit option#3578
Open
florian-dacosta wants to merge 1 commit intoOCA:18.0from
Open
[18] attachment_queue: Fix compatibility with queue job allow commit option#3578florian-dacosta wants to merge 1 commit intoOCA:18.0from
florian-dacosta wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @sebastienbeau, |
A refactore should be considered to get rid of the commit in case of failure
florian-dacosta
force-pushed
the
18-attachment-queue-allow-commit
branch
from
089f131 to
60e24e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #3577
already needed by last version of
queue_job