[18.0][FIX] Fix tests due to change in Odoo upstream#567
[18.0][FIX] Fix tests due to change in Odoo upstream#567OCA-git-bot merged 1 commit intoOCA:18.0from
Conversation
lmignon
force-pushed
the
18.0-fix-tests
branch
2 times, most recently
from
215f780 to
6369af3
Compare
lmignon
changed the title
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
LGTM. The change themes to work, but I am not an expert in this area.
But shouldn't we make one commit for each module with a correct commit massage?
[FIX] : ....
| @@ -48,6 +48,11 @@ def cleanup_tempdir(): | |||
|
|
|||
| def setUp(self): | |||
| super().setUp() | |||
There was a problem hiding this comment.
shouldn't the result be returned at the end like in storage_thumbnail?
There was a problem hiding this comment.
no result is expected when calling setUp.
There was a problem hiding this comment.
I know, but you did it different in the last module.
It's a transversal fix that will not be forward ported. It only changes tests. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 320c1e6. Thanks a lot for contributing to OCA. ❤️ |
| # Remove check_attrs cleanup if exists to avoid conflict with FakeModelLoader. | ||
| # since superClass uses it for its own puposes not relevant for our tests. | ||
| check_attrs = (getattr(self, "check_attrs", None), tuple(), {}) | ||
| if check_attrs in self._cleanups: |
There was a problem hiding this comment.
Defining check_attrs empty should do the same while being more explicit on the intent and more resilient to Odoo changes.
class FsFolderTestCase(TransactionCase):
# Remove tests that are incompatible with FakeModuleLoader
def check_attrs(self):
passAny reason to not do it this way ?
4 participants
No description provided.