14524 histogram adjustments - #14526
Merged
Merged
Conversation
kriben
commented
Aug 14, 2026
kriben
left a comment
kriben
left a comment
Collaborator
Author
There was a problem hiding this comment.
The result-aware binning and filter annotation are useful improvements, and preserving persisted binning choices is handled carefully. I found two edge cases to address: binning changes currently mutate a shared x-axis based on one curve, and the filter annotation does not account for the collection-level visibility toggle.
This review was prepared by an automated review bot working on behalf of @kriben.
magnesj
requested changes
Aug 19, 2026
magnesj
left a comment
magnesj
left a comment
Member
There was a problem hiding this comment.
Consider RiuDraggableOverlayFrame
…o text Select logarithmic binning and a logarithmic x-axis automatically when creating a grid statistics histogram plot from a 3D view showing a logarithmic result (RiaResultNames::isLogarithmicResult). Show a plot info label at the top right of the plot canvas describing active data filters: "Filter: Visible cells in 3D view" when a cell filter view is set, and "Filter: User defined x-range [min..max]" when the bin range is user-defined. The label collects unique filter descriptions from the data sources of all visible curves and is removed when no filters are active.
…hmic property Selecting a logarithmic result manually in the grid statistics data source property editor now enables logarithmic binning and a logarithmic x-axis, the same as creating the plot from a 3D view. The previously selected result variable is tracked so that only an actual property change enables logarithmic binning: other property edits leave a user-selected binning mode alone, and binning modes stored in project files are kept as-is on load.
… property Make the property-driven binning mode symmetric: selecting a non-logarithmic result (e.g. FLUXNUM) after a logarithmic one (e.g. PERMX) sets the binning mode and x-axis back to linear. Replace the one-way logarithmicBinningEnabled signal with a binningModeChanged signal carrying the new mode, so the x-axis scale follows the binning mode in both directions, also when the binning mode itself is changed in the UI.
A user-defined bin range is tied to the value range of a specific result: a range set up for FLUXNUM does not apply to PERMX. Reset the bin range mode to Automatic and the min/max cutoffs to their defaults when another property is selected, and reset the stale cutoffs when the user sets the bin range mode back to Automatic.
Initialize the min and max cutoffs to the data range of the selected result when the bin range mode is set to User Defined. The previous fixed default of [0..1] excluded most values for results like PERMX. The data range is computed by the same statistics query as the histogram, respecting the selected time step and an active visible-cells filter, but without custom binning so min and max are the range of the data.
kriben
force-pushed
the
14524-histogram-adjustments
branch
from
August 19, 2026 09:09
3f153a0 to
f1fe2cb
Compare
magnesj
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14524.