#14514 Add option to include list of dates into schedule file - #14530
Open
kriben wants to merge 6 commits into
Open
#14514 Add option to include list of dates into schedule file#14530kriben wants to merge 6 commits into
kriben wants to merge 6 commits into
Conversation
GenerateSchedule gains an AdditionalDates parameter (ISO date strings). The dates are merged, deduplicated and sorted with the event dates and each becomes a DATES keyword even when no events fall on it, ensuring a summary report at that date in Eclipse/Flow. They are deliberately not filtered by the last applied timestamp. The ORIONEVENTS 2.0 format gains a top-level REPORT <date-expr> directive (date variables and day arithmetic supported). Parsed dates are collected on OrionDocument.report_dates and surfaced by the applier as sorted ISO strings on ApplyReport.report_dates, ready to pass to generate_schedule_text(additional_dates=...).
They are not planned as part of the file format. PERFID on a completion event is now an unknown-attribute error like any other unrecognized key, and DSHIFT on keyword events is forwarded unchanged instead of being stripped with a warning. FILTER keeps its ignore-with-warning behavior outside PERFORATION events.
kriben
force-pushed
the
14514-orion-events-report-dates
branch
from
August 14, 2026 16:05
af77d7c to
ad2a87b
Compare
kriben
commented
Aug 14, 2026
kriben
left a comment
kriben
left a comment
Collaborator
Author
There was a problem hiding this comment.
This adds useful REPORT-date parsing and schedule plumbing, with good parser and integration coverage. I found two edge cases in the date merge: an additional date can re-enable events excluded by set_timestamp(), and an earliest report date is emitted only as a comment by default. Both can violate the expectation that REPORT dates produce report-only DATES entries.
Note: This review was prepared by an automated review bot working on behalf of @kriben.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc ORION events fixes.
Fixes #14514.
Fixes #14533.
Fixes #14535.
Fixes #14537.