cuda: avoid unreachable loop in host throw macros - #5293
Merged
Conversation
akva2
added
the
manual:irrelevant
This was referenced Aug 14, 2026
Member
Author
|
jenkins build this opm-grid=1062 opm-simulators=7325 please |
multitalentloes
approved these changes
Aug 19, 2026
multitalentloes
left a comment
multitalentloes
left a comment
Member
There was a problem hiding this comment.
This changes the macros only when compiling a CPU function from the CUDA / HIP compilers and should not cause any functional changes.
Change looks good to me and build is green, but I cannot actually access the jenkins build myself and see that that the errors were removed, not sure why.
Member
Author
|
build is too old, we only retain 10 builds for space reasons. |
Member
Author
|
jenkins build this opm-grid=1062 opm-simulators=7325 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sadly, nvcc is a d and throws a
Warning #128-D: unreachable loopwhen it encounters the macro-block idiom. As broad suppression of this warning is not very nice, this takes another approach and crafts different macros for when building with nvcc.This gets rid of the warning, at a cost of generating some other warnings from the cpu side compiler (sigh). Those need to be addressed in separate PRs, which, while independent as such, I'll cite as downstreams of this since they are related.