Throw instead of asserting on a non-positive step and a non-finite change - #7355
Draft
hnil wants to merge 1 commit into
Draft
Throw instead of asserting on a non-positive step and a non-finite change#7355hnil wants to merge 1 commit into
hnil wants to merge 1 commit into
Conversation
…ange Both conditions come from the run rather than from a broken invariant, so they should be reported rather than disappear in a release build: - AdaptiveSimulatorTimer: five asserts that the step size is positive. If the controller ever hands over zero, an NDEBUG build carries on with it. - The convergence measure: a non-finite solution change is a diverging solution, not a programming error, and it is worth saying so. Reapplied from OPM#4566, which predates the ebos rename and no longer merges. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hnil
added
the
manual:enhancement
Member
|
Is there more work coming here? I only ask because the PR is in a draft state and not marked "ready for review" yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both conditions come from the run rather than a broken invariant, so they should be reported rather than vanish in a release build:
AdaptiveSimulatorTimer— five asserts that the step size is positive. If the controller ever hands over zero, anNDEBUGbuild carries on with it.Reapplied from #4566, which predates the ebos rename and no longer merges. All the target asserts are still there on master, just in renamed files, so the concern outlived the branch.