Switch to Using RstState::Load() Without Runspec - #7360
Merged
Conversation
PR OPM/opm-common#5308 added an overload of RstState::load() that does not require a "Runspec" argument. While we do have such an object here the restart file loading mechanism should not depend on the dimensions set in the restarted run. Restarted runs may increase such dimensions, e.g., the number of actions or conditions per action, so it's better to not provide those values in any way. We still pass the run's number of PVT tables as an argument to load(). This will be subject to future removal once load() supports this mode.
bska
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates restart-state loading in opm-simulators to use the newer Opm::RestartIO::RstState::load() overload that does not require a Runspec, reducing coupling between restart loading and restarted-run dimension settings.
Changes:
- Switch
RstState::load()call site to the overload that omitsRunspec. - Pass only the number of PVT tables (from
Runspec::tabdims()) plus the input grid pointer to preserve current behavior while avoiding broaderRunspecdependency.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akva2
approved these changes
Aug 26, 2026
Member
Author
|
PR approved and build check is green. I'll merge into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR OPM/opm-common#5308 added an overload of
RstState::load()that does not require aRunspecargument. While we do have such an object here the restart file loading mechanism should not depend on the dimensions set in the restarted run. Restarted runs may increase such dimensions, e.g., the number of actions or conditions per action, so it's better to not provide those values in any way.We still pass the run's number of PVT tables as an argument to
load(). This will be subject to future removal onceload()supports this mode.