74xx595 logic and Arduino 1.6.7 compiler fix#32
Open
Asbjoern wants to merge 1 commit intoOSCSYS:developfrom
Open
74xx595 logic and Arduino 1.6.7 compiler fix#32Asbjoern wants to merge 1 commit intoOSCSYS:developfrom
Asbjoern wants to merge 1 commit intoOSCSYS:developfrom
Conversation
74xx595 uses inverse logic on enable pin. muxDataPin.set(bool) does not work (Arduino 1.6.7 problem?) Logic expanded to use .set() and .clear() instead. Arduino 1.6.7 does not like static const declaration.
Member
|
Thank you for the commit. I need to evaluate the impact to the BT 3.x and On Tue, Feb 23, 2016 at 2:31 AM Asbjørn Mejnertsen notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make the following code changes to get Brewtroller to work on my board (Based on DX2).
74xx595 uses inverted logic on enable pin.
muxDataPin.set(bool) does not work (Arduino 1.6.7 problem?) Logic
expanded to use .set() and .clear() instead.
Arduino 1.6.7 does not like static const declaration.