r.surf.volcano: port from grass6 addons shell script#1202
Open
HamishB wants to merge 6 commits intoOSGeo:grass8from
Open
r.surf.volcano: port from grass6 addons shell script#1202HamishB wants to merge 6 commits intoOSGeo:grass8from
HamishB wants to merge 6 commits intoOSGeo:grass8from
Conversation
neteler
reviewed
Sep 8, 2024
Member
|
Nice! |
MN: for addons, the full URL to core modules is needed here Co-authored-by: Markus Neteler <markus@neteler.org>
Contributor
Author
Hi Markus, What do you like that to look like? Just some dummy values to see if it completes with exit code 0 or some r.univar or 'r.stats -Ac nsteps=10' analysis to see that the output is within expected bounds? |
Member
|
Yes, something simple would be great. This quite helps to be able to quickly test also other changes which might indirectly affect this addon. |
Yeah, I know, but I don't enjoy working with Python.
wenzeslaus
reviewed
Sep 18, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Happy to see this one back.
| # # FIXME: ok, it isn't really kurtosis but it's similar and I couldn't | ||
| # # think of a better name. | ||
| # %Option | ||
| # % key: kurtosis |
| sigma = options["sigma"] | ||
| kurtosis = options["kurtosis"] | ||
|
|
||
| tmp_base = "tmp__rsv_%d" % os.getpid() |
Comment on lines
+89
to
+90
| from grass.script import core as gc | ||
| from grass.script import raster as gr |
Member
There was a problem hiding this comment.
Suggested change
| from grass.script import core as gc | |
| from grass.script import raster as gr | |
| import grass.script as gs |
is what is usually used for simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find this module quite useful for creating synthetic surfaces for testing a variety of other modules.