Show display username instead of email handle on dashboard - #11
Merged
Conversation
Dashboard greeting and sidebar now show the user's chosen username (falling back to the email handle until they set one), with a new Settings page to set it. Backed by the Octo-Protocol PATCH /v1/auth/me endpoint.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dashboard greeting used the local-part of the user's email (e.g. "Good morning, lateeftosin1999") instead of a real name, and there was no way for a user to set one.
What changed
Where
Solution
Falls back to the current email-handle behavior everywhere until a username is set, so nothing breaks for existing users before the backend field is populated. Verified end-to-end in a browser against a local instance of the companion backend PR (Octo-Protocol#210): set a username on the Settings page, confirmed the sidebar updates immediately, and confirmed a fresh page load of the dashboard shows "Good afternoon, " fetched from the real API.
Depends on the backend PR (Octo-Protocol-org/Octo-Protocol#210) for the `username` field and `PATCH /v1/auth/me` endpoint to actually persist a value — without it, this PR is functionally a no-op (email-handle fallback only).