Add settings for claude sandbox#2031
Merged
Merged
Conversation
…d-settings-for-claude-sandbox
This reverts commit 6c3d710.
liam-mackie
approved these changes
Jun 24, 2026
|
|
||
| public static class SandboxSettingsWriter | ||
| { | ||
| const string ClaudeDirName = ".claude"; |
Contributor
There was a problem hiding this comment.
Should this be something we put at a top-level static somewhere instead? I've used this exact pattern too 😓
Contributor
Author
There was a problem hiding this comment.
I'll let you move it in your PR as a clean up
…haviour.cs Co-authored-by: Liam Mackie <liam.mackie@octopus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to MD-2116
Related to MD-2135
Changes from many separate properties to a single json blob for sandbox settings, configured via server.
This matches the strategy we're doing for permissions configuration, where users can enter the values in json via the UI, which more closely matches how they use Claude locally + is more flexible.
We remove a lot of defaults in this change, instead we can set these on the frontend. This also gives users more flexibility.
While I'm here, I renamed Srt references to SandboxRuntime (requested by Liam)