This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Add additional build info properties and parameterize VcsType#4
Open
joeypiccola wants to merge 2 commits intoOctopusDeployLabs:mainfrom
Open
Add additional build info properties and parameterize VcsType#4joeypiccola wants to merge 2 commits intoOctopusDeployLabs:mainfrom
joeypiccola wants to merge 2 commits intoOctopusDeployLabs:mainfrom
Conversation
jschwanz
reviewed
Jul 1, 2022
| BuildUrl: "$CIRCLE_BUILD_URL", | ||
| Branch: "$CIRCLE_BRANCH", | ||
| VcsType: "GitHub" | ||
| VcsType: "<< parameters.vcs_type >>", |
There was a problem hiding this comment.
You can probably make this dynamic, too, by using << pipeline.project.type >>. See https://circleci.com/docs/2.0/variables#pipeline-values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things.
VcsTypeused in the build information. Defaults toGitHub.VcsRootandVcsCommitNumber. Build information submitted without aVcsRootis 100% functional but complains aboutNo VCS root configured(shown below).This may also fix an issue when
create-releaseis called. Mycreate-releasejob errors with the following.