Update tests to handle more failures.#241
Merged
Rick-Kirkham merged 4 commits intoJul 20, 2026
Merged
Conversation
Rick-Kirkham
previously approved these changes
Jul 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the end-to-end testing harness to surface and fail on a broader set of failures (timeouts, initialization errors, and host-run exceptions) by sending structured error results back to the test runner.
Changes:
- Add a timeout around retrieving test results and fail fast when the taskpane never reports results.
- Report initialization/ping failures and host-run exceptions via a dedicated
"test-error"result and improved error formatting. - Update TypeScript compiler settings and npm registry configuration (note: these are outside the PR’s stated test-only scope).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Updates TS compilation settings; also currently includes an invalid trailing comma and changes outside the PR’s stated scope. |
| test/end-to-end/ui-test.ts | Adds result timeout handling and fails tests when a "test-error" result is reported. |
| test/end-to-end/src/test.index.tsx | Catches initialization/ping failures and posts error results back to the test server. |
| test/end-to-end/src/test-helpers.ts | Adds helpers for structured error results and consistent error formatting. |
| test/end-to-end/src/host-tests.ts | Ensures host-run calls are awaited and reports exceptions as "test-error" results. |
| .npmrc | Switches npm registry to an internal proxy (impacts installs/runs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rick-Kirkham
previously approved these changes
Jul 20, 2026
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved the merge conflict by merging latest |
Rick-Kirkham
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description:
Update end-to-end test code to handle failures beyond the APIs returning the wrong values. This includes catching exceptions in running the tests and running the APIs themselves.
Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
No.
Do these changes impact VS Code debugging options (launch.json)?
No.
Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
No.
Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
No.
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed:
Ran automated test.